[rewrite] apply JavaLangAPIs #2804#2810
Merged
Goooler merged 1 commit intodiffplug:mainfrom Jan 10, 2026
Merged
Conversation
Pankraz76
commented
Jan 10, 2026
| failOnDryRunResults = true | ||
| } | ||
| dependencies { | ||
| rewrite('org.openrewrite.recipe:rewrite-migrate-java:3.22.0') |
| name: com.diffplug.spotless.openrewrite.SanityCheck | ||
| displayName: Apply all Java & Gradle best practices | ||
| description: Comprehensive code quality recipe combining modernization, security, and best practices. | ||
| tags: |
| - org.openrewrite.staticanalysis.RemoveUnusedLocalVariables | ||
| - org.openrewrite.staticanalysis.RemoveUnusedPrivateFields | ||
| - org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods | ||
| - org.openrewrite.staticanalysis.ReplaceApacheCommonsLang3ValidateNotNullWithObjectsRequireNonNull |
Author
There was a problem hiding this comment.
this was "just" to see. its very specific, imho should go the simple way.
| - tech.picnic.errorprone.refasterrules.StreamRulesRecipes | ||
| - tech.picnic.errorprone.refasterrules.StringRulesRecipes | ||
| - tech.picnic.errorprone.refasterrules.TimeRulesRecipes | ||
| # - org.openrewrite.java.migrate.lang.FindVirtualThreadOpportunities # don't want to use: https://github.com/diffplug/spotless/pull/2684#discussion_r2433831887 |
Author
There was a problem hiding this comment.
this was "just" to see. its very specific, imho should go the simple way.
Pankraz76
commented
Jan 10, 2026
| # BUILDCACHE_USER | ||
| # BUILDCACHE_PASS | ||
| # - rw access to buildcache.diffplug.com | ||
|
|
Author
There was a problem hiding this comment.
this would help to avoid a lot of noice.
of course the icons are open to debate, im sure you request to remove for the same reason :)
Author
Goooler
approved these changes
Jan 10, 2026
Author
|
ty. |
Pankraz76
commented
Jan 10, 2026
| - org.openrewrite.java.format.RemoveTrailingWhitespace | ||
| - org.openrewrite.java.migrate.UpgradeToJava17 | ||
| - org.openrewrite.java.migrate.lang.StringRulesRecipes | ||
| - org.openrewrite.java.migrate.util.JavaLangAPIs |
Author
There was a problem hiding this comment.
thats actually wrong how could this pass ci..
Recipe validation error in com.diffplug.spotless.openrewrite.SanityCheck for property com.diffplug.spotless.openrewrite.SanityCheck.recipeList[13] (in file:/home/runner/work/spotless/spotless/rewrite.yml): recipe 'org.openrewrite.java.migrate.util.JavaLangAPIs' does not exist.
fixed in:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[rewrite] apply
JavaLangAPIs#2804as kindly requested: @Goooler